feat(auction): upgrade handler and params #2526
Conversation
|
Warning Rate Limit Exceeded@robert-zaremba has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 43 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe changes involve introducing a new upgrade Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- app/upgrades.go (2 hunks)
- x/leverage/types/params.go (1 hunks)
- x/metoken/params.go (1 hunks)
Additional Context Used
GitHub Check Runs (8)
test-unit-cover failure (8)
app/upgrades.go: [failure] 86-86:
syntax error: unexpected newline in composite literal; possibly missing comma or }umeed linux-arm64 cancelled (3)
app/upgrades.go: [failure] 86-86:
syntax error: unexpected newline in composite literal; possibly missing comma or }umeed darwin-arm64 failure (3)
app/upgrades.go: [failure] 86-86:
syntax error: unexpected newline in composite literal; possibly missing comma or }umeed linux-amd64 failure (3)
app/upgrades.go: [failure] 86-86:
syntax error: unexpected newline in composite literal; possibly missing comma or }umeed darwin-amd64 failure (3)
app/upgrades.go: [failure] 86-86:
syntax error: unexpected newline in composite literal; possibly missing comma or }test-app-non-determinism failure (3)
app/upgrades.go: [failure] 86-86:
syntax error: unexpected newline in composite literal; possibly missing comma or }Run golangci-lint failure (8)
app/upgrades.go: [failure] 86-86:
syntax error: unexpected newline in composite literal; possibly missing comma or } (typecheck)
app/upgrades.go: [failure] 86-86:
missing ',' before newline in composite literal (typecheck)
app/upgrades.go: [failure] 86-86:
syntax error: unexpected newline in composite literal; possibly missing comma or }) (typecheck)
app/upgrades.go: [failure] 86-86:
syntax error: unexpected newline in composite literal; possibly missing comma or }) (typecheck)Run govulncheck failure (6)
app/upgrades.go: [failure] 86-86:
missing ',' before newline in composite literal
app/upgrades.go: [failure] 70-70:
not enough return values
app/upgrades.go: [failure] 77-77:
not enough return values
app/upgrades.go: [failure] 85-85:
undefined: auction
Additional comments not posted (3)
x/metoken/params.go (1)
8-8: LGTM! TheRewardsAuctionFactorupdate aligns with the PR objectives.x/leverage/types/params.go (1)
15-15: LGTM! TheRewardsAuctionFactorupdate aligns with the PR objectives.app/upgrades.go (1)
55-57: LGTM! The addition ofregisterUpgrade6_5aligns with the PR objectives.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
swagger/swagger.yamlis excluded by!**/*.yamlx/metoken/metoken.pb.gois excluded by!**/*.pb.go,!**/*.pb.go
Files selected for processing (6)
- app/upgrades.go (2 hunks)
- proto/umee/metoken/v1/metoken.proto (1 hunks)
- x/metoken/keeper/intest/msg_server_test.go (2 hunks)
- x/metoken/keeper/swap.go (1 hunks)
- x/metoken/keeper/swap_test.go (2 hunks)
- x/metoken/params.go (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- app/upgrades.go
- x/metoken/params.go
Additional comments not posted (4)
x/metoken/keeper/swap_test.go (2)
44-44: Update parameter name toRewardsAuctionFeeFactor.The change correctly updates the parameter name to
RewardsAuctionFeeFactorin the assertion.
91-91: Update parameter name toRewardsAuctionFeeFactor.The change correctly updates the parameter name to
RewardsAuctionFeeFactorin the assertion.proto/umee/metoken/v1/metoken.proto (1)
22-26: Rename field torewards_auction_fee_factor.The field name change to
rewards_auction_fee_factoris correct, and the comments accurately describe the field.x/metoken/keeper/swap.go (1)
188-189: Update parameter name toRewardsAuctionFeeFactor.The change correctly updates the parameter name to
RewardsAuctionFeeFactorin the fee calculation.
robert-zaremba
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
swagger/swagger.yamlis excluded by!**/*.yamlx/leverage/types/leverage.pb.gois excluded by!**/*.pb.go,!**/*.pb.gox/metoken/metoken.pb.gois excluded by!**/*.pb.go,!**/*.pb.go
Files selected for processing (8)
- app/upgrades.go (2 hunks)
- proto/umee/leverage/v1/leverage.proto (1 hunks)
- proto/umee/metoken/v1/metoken.proto (1 hunks)
- x/leverage/fixtures/params.go (1 hunks)
- x/leverage/keeper/interest.go (2 hunks)
- x/leverage/keeper/interest_test.go (1 hunks)
- x/leverage/types/params.go (1 hunks)
- x/metoken/params.go (1 hunks)
Files not reviewed due to errors (3)
- x/leverage/keeper/interest_test.go (no review received)
- x/leverage/keeper/interest.go (no review received)
- proto/umee/leverage/v1/leverage.proto (no review received)
Files skipped from review due to trivial changes (1)
- x/leverage/fixtures/params.go
Files skipped from review as they are similar to previous changes (3)
- app/upgrades.go
- proto/umee/metoken/v1/metoken.proto
- x/leverage/types/params.go
Additional comments not posted (1)
x/metoken/params.go (1)
6-8: LGTM! The default value forRewardsAuctionFeeFactorhas been updated to 100%.
robert-zaremba
force-pushed
the
robert/auction-upgrade
branch
from
73a552e to
e4d4427
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- app/upgrades.go (2 hunks)
Additional Context Used
GitHub Check Runs (7)
umeed linux-arm64 failure (3)
app/upgrades.go: [failure] 27-27:
"github.com/umee-network/umee/v6/x/metoken" imported and not usedumeed darwin-arm64 failure (3)
app/upgrades.go: [failure] 27-27:
"github.com/umee-network/umee/v6/x/metoken" imported and not usedumeed linux-amd64 failure (3)
app/upgrades.go: [failure] 27-27:
"github.com/umee-network/umee/v6/x/metoken" imported and not usedumeed darwin-amd64 failure (3)
app/upgrades.go: [failure] 27-27:
"github.com/umee-network/umee/v6/x/metoken" imported and not usedRun golangci-lint failure (7)
app/upgrades.go: [failure] 27-27:
"github.com/umee-network/umee/v6/x/metoken" imported and not used (typecheck)
app/upgrades.go: [failure] 27-27:
"github.com/umee-network/umee/v6/x/metoken" imported and not used) (typecheck)
app/upgrades.go: [failure] 27-27:
"github.com/umee-network/umee/v6/x/metoken" imported and not used) (typecheck)test-app-non-determinism failure (3)
app/upgrades.go: [failure] 27-27:
"github.com/umee-network/umee/v6/x/metoken" imported and not usedRun govulncheck failure (3)
app/upgrades.go: [failure] 27-27:
"github.com/umee-network/umee/v6/x/metoken" imported and not used
Additional comments not posted (2)
app/upgrades.go (2)
57-57: LGTM! The addition ofregisterUpgrade6_5is consistent with the existing pattern.
60-88: LGTM! TheregisterUpgrade6_5function correctly updates the leverage and metoken parameters and handles errors appropriately.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
===========================================
- Coverage 75.38% 62.77% -12.62%
===========================================
Files 100 275 +175
Lines 8025 15889 +7864
===========================================
+ Hits 6050 9975 +3925
- Misses 1589 5141 +3552
- Partials 386 773 +387
|
Description
Before merging need to decide about default params for leverage and metoken